Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added valuation of quantity for each age group in stock ageing … #45076

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mihir-kandoi
Copy link
Contributor

In response to FC ERPNext helpdesk ticket 22875

A new column has been added for each age group which shows the valuation for the same

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 3, 2025
@mihir-kandoi mihir-kandoi marked this pull request as ready for review January 4, 2025 11:13
@@ -18,6 +18,7 @@ def test_normal_inward_outward_queue(self):
name="Flask Item",
actual_qty=30,
qty_after_transaction=30,
stock_value_difference=0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why zero? put some value for testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't created a specific test case of ageing valuation. These all values are for existing tests. I put 0 as they were irrelevant for their test's purpose.

Shall I create a test case for ageing valuation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants