Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow Table fieldtype while converting Lead to Deal #648

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

pu-raihan
Copy link
Contributor

Summary of Changes:

Removed Table from restricted_fieldtypes to allow child tables in Lead-to-Deal conversion.
Added status_change_log to restricted_map_fields to prevent log data transfer.
This update ensures better flexibility in handling related data while maintaining necessary restrictions.

in class decl. of CRM Lead, in create_deal function.

Before

restricted_fieldtypes = [
			"Tab Break",
			"Section Break",
			"Column Break",
			"HTML",
			"Button",
			"Attach",
			"Table",
		]
		restricted_map_fields = [
			"name",
			"naming_series",
			"creation",
			"owner",
			"modified",
			"modified_by",
			"idx",
			"docstatus",
			"status",
			"email",
			"mobile_no",
			"phone",
			"sla",
			"sla_status",
			"response_by",
			"first_response_time",
			"first_responded_on",
			"communication_status",
			"sla_creation",
		]

After

restricted_fieldtypes = [
			"Tab Break",
			"Section Break",
			"Column Break",
			"HTML",
			"Button",
			"Attach",
--		]
		restricted_map_fields = [
			"name",
			"naming_series",
			"creation",
			"owner",
			"modified",
			"modified_by",
			"idx",
			"docstatus",
			"status",
			"email",
			"mobile_no",
			"phone",
			"sla",
			"sla_status",
			"response_by",
			"first_response_time",
			"first_responded_on",
			"communication_status",
			"sla_creation",
++			"status_change_log",
		]

@shariquerik shariquerik merged commit f8394c3 into frappe:develop Mar 10, 2025
1 check passed
@shariquerik
Copy link
Member

🎉 This PR is included in version 1.38.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants