fix: allow read permission for crm settings

frappe · Dec 30, 2024 · 38b4c37 · 38b4c37
1 parent c073206
commit 38b4c37
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/crm/fcrm/doctype/fcrm_settings/fcrm_settings.json b/crm/fcrm/doctype/fcrm_settings/fcrm_settings.json
@@ -61,7 +61,7 @@
  "index_web_pages_for_search": 1,
  "issingle": 1,
  "links": [],
- "modified": "2024-12-27 22:17:52.337109",
+ "modified": "2024-12-30 19:03:51.898913",
  "modified_by": "Administrator",
  "module": "FCRM",
  "name": "FCRM Settings",
@@ -76,6 +76,13 @@
    "role": "System Manager",
    "share": 1,
    "write": 1
+  },
+  {
+   "email": 1,
+   "print": 1,
+   "read": 1,
+   "role": "All",
+   "share": 1
   }
  ],
  "sort_field": "creation",

diff --git a/frontend/src/components/Settings/Settings.vue b/frontend/src/components/Settings/Settings.vue
@@ -121,6 +121,7 @@ const tabs = computed(() => {
           component: markRaw(ERPNextSettings),
         },
       ],
+      condition: () => isManager(),
     },
   ]
-Original file line number
+Diff line change
@@ Expand Up / @@ -121,6 +121,7 @@ const tabs = computed(() => { @@
               component: markRaw(ERPNextSettings),
             },
           ],
+          condition: () => isManager(),
         },
       ]
@@ Expand Down @@