Use block dataKey instead of block key for define for variable name #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To construct a UI like below
We often need to use
repeater
block, internally the repeater block define a key based on the blockKey, what create codes likeThis code works because internally, the builder defined a variable
key_{block.get('blockId')}
, but it makes impractical to deal with that in the long term!Reasons are:
1 - We dont have any reference on the UI that tell us that my block have the id
u7ps3awh6
2 - The block ID is internally controlled by the framework, what means, if we duplicate the block, the logic breaks and again we dont have hints about the new variable name!
My proposal is to make use of the
dataKey
of therepeater
block, to generate a more organic key like below