Skip to content

Allow NATS messages without message-type header when DefaultIncomingMessage is set #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankvdb7 merged 3 commits into from
May 7, 2026
+54 −3
Merged

Allow NATS messages without message-type header when DefaultIncomingMessage is set #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a298aa8
Fix bug where message_type header was required for NATS even with Def…
frankvdb7 May 7, 2026
78890cd
Fix bug where message_type header was required for NATS even with Def…
frankvdb7 May 7, 2026
0468a6a
Fix bug where message_type header was required for NATS even with Def…
frankvdb7 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Transports/NATS/Wolverine.Nats/Internal/CoreNatsSubscriber.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ var msg in ((INatsSub<byte[]>)subscription).Msgs.ReadAllAsync(cancellation)
// Skip messages without headers or without message-type header.
// These are typically NATS protocol messages (JetStream acks, etc.)
// that should not be processed by Wolverine.
if (msg.Headers == null || !msg.Headers.ContainsKey("message-type"))
if (_endpoint.MessageType == null && (msg.Headers == null || !msg.Headers.ContainsKey("message-type")))
Comment thread
frankvdb7 marked this conversation as resolved.
{
_logger.LogDebug(
"Skipping NATS message without message-type header from subject {Subject}. DataLength={DataLength}, HasHeaders={HasHeaders}",
Expand Down
2 changes: 1 addition & 1 deletion src/Transports/NATS/Wolverine.Nats/Internal/JetStreamSubscriber.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ CancellationToken cancellation

// Skip messages without headers or without message-type header.
// These are typically NATS protocol messages that should not be processed by Wolverine.
if (msg.Headers == null || !msg.Headers.ContainsKey("message-type"))
if (_endpoint.MessageType == null && (msg.Headers == null || !msg.Headers.ContainsKey("message-type")))
Comment thread
frankvdb7 marked this conversation as resolved.
{
await msg.AckAsync(cancellationToken: cancellation);
continue;
Expand Down
Loading