Skip to content

Fix DLQ inheritance for RabbitMQ tenants#1

Merged
frankvdb7 merged 3 commits intomainfrom
codex/fix-dead-letter-queue-inheritance-for-tenants
Jun 27, 2025
Merged

Fix DLQ inheritance for RabbitMQ tenants#1
frankvdb7 merged 3 commits intomainfrom
codex/fix-dead-letter-queue-inheritance-for-tenants

Conversation

@frankvdb7
Copy link
Owner

Summary

  • clone parent dead letter queue settings to tenant transports
  • test that global dead letter queues apply to tenants
  • clarify comment style

Testing

  • dotnet test src/Transports/RabbitMQ/Wolverine.RabbitMQ.Tests/Wolverine.RabbitMQ.Tests.csproj --verbosity minimal (fails: missing .NET 8 runtime)

https://chatgpt.com/codex/tasks/task_b_685e7d2e5a64832aa0c1ec993a88f38c

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @frankvdb7, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where dead letter queue settings were not being properly inherited by RabbitMQ tenants. The changes ensure that tenant transports inherit the DLQ configuration from their parent, maintaining consistency across tenants. Additionally, tests have been added to validate this behavior.

Highlights

  • DLQ Inheritance: Clones parent dead letter queue settings to tenant transports, ensuring tenant-specific queues are declared consistently with the parent.
  • Testing: Adds tests to verify that global dead letter queues apply correctly to tenants, both when the tenant is created before and after the DLQ configuration.
  • RabbitMqTenant.cs: Modified the Compile method in RabbitMqTenant.cs to clone the parent's dead letter queue configuration to the tenant's transport.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces changes to clone parent dead letter queue settings to tenant transports and adds tests to verify that global dead letter queues apply to tenants. The changes improve the consistency of dead letter queue configurations across tenants.

@frankvdb7 frankvdb7 merged commit 2e3bae6 into main Jun 27, 2025
@frankvdb7 frankvdb7 deleted the codex/fix-dead-letter-queue-inheritance-for-tenants branch June 27, 2025 14:32
frankvdb7 added a commit that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant