CMake: add deprecation warning for QTKEYCHAIN_STATIC#205
Merged
frankosterfeld merged 1 commit intofrankosterfeld:masterfrom Nov 15, 2021
Merged
CMake: add deprecation warning for QTKEYCHAIN_STATIC#205frankosterfeld merged 1 commit intofrankosterfeld:masterfrom
frankosterfeld merged 1 commit intofrankosterfeld:masterfrom
Conversation
The default for the old QTKEYCHAIN_STATIC variable was OFF, which is effectively the same as the new default BUILD_SHARED_LIBS=ON, so there is no need to warn in that case.
KitsuneRal
approved these changes
Nov 14, 2021
Contributor
KitsuneRal
left a comment
KitsuneRal
left a comment
There was a problem hiding this comment.
Thanks, that should be good enough.
Contributor
Author
|
Thanks for the quick merge. Could you tag a new release so I can simplify the packaging scripts in vcpkg? |
Owner
|
@Be-ing done |
Contributor
Author
|
Thanks, here is the PR to update vcpkg: microsoft/vcpkg#21529 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default for the old QTKEYCHAIN_STATIC variable was OFF, which
is effectively the same as the new default BUILD_SHARED_LIBS=ON,
so there is no need to warn in that case.