-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sycamore to v0.6.0 #10
Conversation
For some reason, clicking on links causes a context error. |
Found it. This line here is not being called inside a reactive scope so it can't access the context: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great, thanks so much!
Okay that makes a lot of sense for the context error. Given though that |
Would you mind quickly running |
Done |
What kind of restrictions are you thinking about? Object-safety? The way I would do it would be to use a global variable since there is only 1 router per app (albeit not being very idiomatic in Rust). Alternatively, I could change something in Sycamore itself to prevent the router from handling click events. This way, we could attach our own click handler and manually call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good!
I'll fix the broken links issue after this is merged as part of the fixes to #8, so this should be good to merge if you're done with it. |
Alright. I'm done then. |
Thanks so much, this is really helpful! |
Updates sycamore to 0.6.0, removes patch dependencies