-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to install perseus-cli 0.3.0-beta.XX
with clap 3.0.0-rc.X
#85
Comments
Ah, thanks for catching this one! I've just finished adding the new integration for Warp, so I'll release the fix for this in the next beta version, which should come out in a few hours. |
Wow, thanks a lot. I will close this issue. By the way, when do you plan to support |
No problem! Sycamore v0.7.0 will ship with the beta after next, which should be out by tomorrow, and then v0.3.0 should be able to go stable! |
Great work! 👍 |
* refactor: moved some functions for integrations into the core package This will make developing more integrations in future much simpler. This also involved standardizing the `Options` taken by all integrations BREAKING CHANGE: `Options` renamed to `ServerOptions` for all integrations * feat: made templates and error pages thread-safe This involved adding an atomic types system. Also added basics for a Warp integration (which needs this thread-safety). * feat: made more things thread-safe and made warp integration nearly work The problem is `Rc<Translator>`s, so some refactoring needs to be done. * feat: added nearly all handlers to warp integration BREAKING_CHANGE: `ServerOptions` now only accepts one static content directory * fix: made `DummyTranslator` `Clone`able * feat: added support for static aliases in the warp integration None of this has been tested yet, so there will likely be bugs. We now depend on my fork of Warp until [this](seanmonstar/warp#924) is merged. * fix: pinned `clap` version Fixes #85. * feat: finalized warp integration It's also now the default in the CLI. * docs: updated docs to reflect warp integration * docs: merged `next` and `0.3.x` docs * chore: extended version replacement script Now covers the `Cargo.toml` files in `examples/basic/.perseus`.
@rieval just so you know what the heck is going on if you've tried to install Perseus again recently, there have been some minor critical failures in the two betas I just released, so we're now at version v0.3.0-beta.21, and the previous two have been yanked. |
Wow, I tested it and it works fine. Honestly, well done! |
No problem, thank you very much! |
I tried to run the following command:
cargo install perseus-cli --version 0.3.0-beta.18
It threw some similar errors: #65 (comment).
Then I noticed that
clap
had released the version3.0.0-rc.X
, so I tried to editingCargo.toml
in theperseus-cli-0.3.0-beta.18
folder.Finally I run the install command again and it runs successfully.
The text was updated successfully, but these errors were encountered: