Skip to content

Conversation

@ikanishakm
Copy link

What is this PR doing
This pull request adjusts the tab order for the Stepper component buttons by setting their tabIndex to -1. This change removes the increment and decrement buttons from the keyboard tab sequence, potentially improving navigation for keyboard users.

Testing

  • Verify tab order behavior

    • Open a page containing the Stepper component
    • Use the Tab key to navigate through the page
    • Confirm that focus skips over the increment and decrement buttons
    • Verify that focus moves directly from the input field to the next focusable element
  • Check button functionality

    • Click on the increment and decrement buttons with a mouse
    • Confirm that the buttons still function correctly when clicked
  • Keyboard accessibility check

    • Focus on the Stepper input field
    • Attempt to use arrow keys or other keyboard shortcuts to increment/decrement the value
    • Note any unexpected behavior or lack of keyboard control

@vercel
Copy link

vercel bot commented Oct 16, 2024

@ikanishakm is attempting to deploy a commit to the Framer Team on Vercel.

A member of the Team first needs to authorize it.

@triozer
Copy link
Member

triozer commented Jun 25, 2025

Thank you for your contribution!

However, removing the stepper buttons from the tab order by setting their ‎tabIndex to -1 would make these controls inaccessible to keyboard and assistive technology users. Accessible interfaces require that all interactive elements, including increment and decrement buttons, remain reachable via keyboard.

@triozer triozer closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants