-
Notifications
You must be signed in to change notification settings - Fork 47
Airtable: add Lookup, Rollup, Barcode, AI Text, User, and Duration fields #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1925b34 to
0052b81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for additional Airtable field types including Lookup, Rollup, Barcode, AI Text, Collaborator, and Duration fields, while also refining data import logic and addressing warning spam.
- Introduced new field inference functions for Barcode, AI Text, Duration, and Collaborator fields.
- Updated number field handling by replacing "duration" with "count" and adjusted API types to remove the deprecated "lookup" type.
- Enhanced field mapping logic and styling adjustments in FieldMapping.tsx and App.css.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/airtable/src/fields.ts | Added new inference functions and properties for additional field types; refactored type handling. |
| plugins/airtable/src/data.ts | Updated field data processing to support new field types and proper value extraction. |
| plugins/airtable/src/api.ts | Modified API types to remove outdated lookup types and align with new field schema. |
| plugins/airtable/src/FieldMapping.tsx | Adjusted UI logic for field type selection and mapping improvements. |
| plugins/airtable/src/App.css | Added styling for the new field-type select component. |
Comments suppressed due to low confidence (2)
plugins/airtable/src/fields.ts:1
- There are no tests currently covering the new field inference logic for Barcode, AI Text, Duration, and Collaborator fields. Please add tests to verify their behavior and ensure reliable functionality.
import type { ManagedCollection, ManagedCollectionFieldInput } from "framer-plugin"
plugins/airtable/src/api.ts:312
- The API type union has been updated by removing the deprecated 'lookup' field type in favor of 'multipleLookupValues'. Please update the documentation accordingly to reflect this breaking change.
| { type: "createdTime"; options: AirtableFieldOptions["createdTime"] }
| * The original Airtable field schema options. | ||
| * Only set when fields are inferred. | ||
| */ | ||
| readonly airtableOptions?: AirtableFieldSchema["options"] |
Copilot
AI
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Multiple inference functions repeat assignments for 'airtableOptions' and 'originalAirtableType'. Consider refactoring this repeated logic into a common helper function to reduce duplication.
0878ee7 to
9d2194c
Compare
|
Closing because I screwed up when rebasing |
Description
This pull request adds support for more field types to the Airtable plugin.
Notes:
Currently marked as draft. Will open for review after I have thoroughly tested all changes.
Testing
None yet.