Revamp Notion plugin #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

madebyisaacr wants to merge 38 commits into framer:main from madebyisaacr:notion-plugin-updates

Closed

Revamp Notion plugin #220

Remove unused code

Annotations

5 errors and 10 warnings

Process completed with exit code 1.

plugins/notion/src/notion.ts#L743

Unexpected lexical declaration in case block

plugins/notion/src/notion.ts#L703

Unexpected lexical declaration in case block

notion#check-eslint: command (/home/runner/work/plugins/plugins/plugins/notion) /tmp/xfs-04ffaab9/yarn run check-eslint exited (1)

plugins/notion/src/blocksToHTML.ts#L99

Unexpected lexical declaration in case block

plugins/dither/src/App.tsx#L120

React Hook useEffect has a missing dependency: 'mesh'. Either include it or remove the dependency array

plugins/dither/src/App.tsx#L62

React Hook useEffect has a missing dependency: 'gl'. Either include it or remove the dependency array

plugins/csv-import/src/App.tsx#L233

The ref value 'form.current' will likely have changed by the time this effect cleanup function runs. If this ref points to a node rendered by React, copy 'form.current' to a variable inside the effect, and use that variable in the cleanup function

plugins/tidyup/src/App.tsx#L682

React Hook useLayoutEffect has a spread element in its dependency array. This means we can't statically verify whether you've passed the correct dependencies

plugins/tidyup/src/App.tsx#L359

React Hook useMemo has an unnecessary dependency: 'randomKey'. Either exclude it or remove the dependency array

plugins/threshold/src/App.tsx#L143

React Hook useEffect has a missing dependency: 'updateCanvas'. Either include it or remove the dependency array

plugins/threshold/src/App.tsx#L127

React Hook useMemo has missing dependencies: 'maxHeight' and 'maxWidth'. Either include them or remove the dependency array

plugins/photobooth/src/App.tsx#L34

React Hook useCallback has a missing dependency: 'animate'. Either include it or remove the dependency array

plugins/color-extract/src/App.tsx#L52

React Hook useEffect has a missing dependency: 'currentSelection'. Either include it or remove the dependency array

plugins/concentric/src/App.tsx#L138

React Hook useEffect has missing dependencies: 'isAllowedToSetAttributes' and 'state'. Either include them or remove the dependency array

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revamp Notion plugin #220

Uh oh!

Uh oh!

Revamp Notion plugin #220

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...