Egui widgets #318
Merged
Egui widgets #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kryptos-FR
added
Project: Shards
Codecov Report
@@ Coverage Diff @@
## devel #318 +/- ##
===========================================
- Coverage 76.46% 45.22% -31.24%
===========================================
Files 155 154 -1
Lines 25957 24928 -1029
===========================================
- Hits 19847 11273 -8574
- Misses 6110 13655 +7545
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Kryptos-FR
force-pushed
the
egui_widgets
branch
2 times, most recently
from
29cda5b
to
cc3b335
Compare
sinkingsugar
requested changes
Jul 19, 2022
sinkingsugar
previously approved these changes
Jul 19, 2022
|
No tests at all ?? :(( |
sinkingsugar
force-pushed
the
egui_widgets
branch
from
ff0d445
to
89e5d76
Compare
I plan to update the egui_demo.edn. Should I also write tests in rust? |
no don't worry. I found the demo test eventually :) |
Closed
UI layout can be deep and having the output of inner shards bubble up is confusing and could lead to unexpected results. It is also unlikely to be practical as widgets are already organized in a logical fashion. Users can always introduce a variable if some inner output needs to be used elsewhere.
guusw
reviewed
Jul 31, 2022
Kryptos-FR
force-pushed
the
egui_widgets
branch
from
ec8fe19
to
90ae4c2
Compare
Code was duplicated when exposing contents variables and when exposing the UI parents.
Kryptos-FR
force-pushed
the
egui_widgets
branch
from
90ae4c2
to
a1bbaad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bunch of
eguiwidgets in shards. There are a few remaining and some optional behaviours are not yet implemented, but it should give a good starting point to design an UI with most of the layout and widgets already in place.widget list
Note that button and label were already implemented in #309.
As it follows #312 where text input is implemented, there are two shared commits here (until #312 is merged).