ISSUE-22: Add support for sqlite #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Because it can easily obtained by the Database itself.
SQLite3 will be disabled nby default. It can be built/enabled via built-tag `sqlite3`. The Makefile exists for convenience. If the new type is used tables-to-go will fail with the message driver not found. Therefore the separate sqlite_driver.go file is introduced. Moved the default username from Settings to Postgres implementation. Created unit tests for DSN methods of Postgres and SQLite.
Updated make file to include vendor'ed build.
chingsungho
pushed a commit
to chingsungho/tables-to-go
that referenced
this pull request
Mar 8, 2025
ISSUE-22: Add support for sqlite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #22 we need to introduce a new driver (https://github.com/mattn/go-sqlite3). It states in its compilation section that it requires
CGO_ENABLED=1and a workinggcccompiler on the target system. This restricts usage of this tool and forces users to provide the correct environment to build it. Therefore I decided to exclude SQLite3 by default and provide a handy way to enable user to build it via a Makefile. The assumption is that user who have the neccessary environment set up are also able to execute a Makefile.Furthermore with a growing number of dependencies and with the latest go1.13 release I want to introduce vendoring and versioning via go modules.
This said, this PR does hereby the following:
sqlite3and an implementation for it.sqlite3which when set builds the new filesqlite_driver.go.