fix: comment out pre-commit clang-tidy for CI #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
ashjeong
force-pushed
the
fix/pre-commit-clang-tidy-CI
branch
2 times, most recently
from
5eae1ec to
66c9e41
Compare
ashjeong
changed the title
chokobole
reviewed
Aug 21, 2025
ashjeong
force-pushed
the
fix/pre-commit-clang-tidy-CI
branch
2 times, most recently
from
f7e0d32 to
58e440c
Compare
Comments out clang-tidy as part of pre-commit as it was causing CI failures. See https://github.com/zk-rabbit/zkir/actions/runs/16904324348/job/47890440254. TODO: fix in future
ashjeong
force-pushed
the
fix/pre-commit-clang-tidy-CI
branch
from
58e440c to
dee4586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is done on top of commit e71eef0, which was failing the pre-commit clang-tidy CI.
See https://github.com/zk-rabbit/zkir/actions/runs/16904324348/job/47890440254 for more details on the CI run failures.
Clang-tidy will be reinstated in the future, but commented out for now for a quick fix. This still works locally, though, so uncomment it as needed.