-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New fract4dc interface #85
New fract4dc interface #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising, but as example C++ code there are a few things that stand out to me.
My comments on malloc() usage still apply thanks to object lifetimes in the C++ VM, but your review of C compat head usage looks good otherwise |
I've applied most of the suggestions from @DX-MON to the examples (need to undo the const_cast though). |
Looks much better, thank you. the rbga_t comment remains, but otherwise approved for merge. Edit: re-checked, you did actually fix that. |
As far as I can tell you should have the same access as a member of the 'fract4d' org. I don't mind granting write access - thought you already had it. |
A new interface for the fract4dc has been created by introducing a new python extension type called
controller
.The goal of this new interface is to avoid objects swinging in and out from fract4dc to python and the other way around all the time (which forces the need of having ugly interfaces and complicates the state handling).
No python scripts have been modified yet but only a new test has been created to demonstrate how to use it. Also the methods that would be deprecated by moving to this new interface have been marked in
fract4d_module.cpp
In addition, a new folder examples has been created containing:
The idea behind all this is to transfer all the knowledge gotten from analyzing and reorganizing the code to future developers.