Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on macOS 13 #263

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Test on macOS 13 #263

merged 1 commit into from
Aug 21, 2024

Conversation

cjmayo
Copy link
Collaborator

@cjmayo cjmayo commented Aug 20, 2024

GitHub is retiring their macOS 12 image.

Not an immediate hurry, 3 and a bit months yet:
https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

GitHub is retiring their macOS 12 image.

gtk4 dependency: [email protected]
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (06e34bb) to head (ef6feaa).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files          55       55           
  Lines       10424    10431    +7     
=======================================
+ Hits         8934     8940    +6     
- Misses       1490     1491    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Lucky that gnofract4d didn't get stuck on the macOS 11 image which got silently retired a couple of months back without warning. Keeps things much simpler.

@cjmayo cjmayo merged commit 4202edc into fract4d:master Aug 21, 2024
9 checks passed
@cjmayo cjmayo deleted the macos-13 branch August 21, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants