Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure installed modules are not executable #261

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Ensure installed modules are not executable #261

merged 1 commit into from
Apr 29, 2024

Conversation

cjmayo
Copy link
Collaborator

@cjmayo cjmayo commented Apr 26, 2024

Match the permissions that were being applied by setuptools.

The difference with Meson was:

 FILES:-usr/lib/python3.11/site-packages/fract4d/createdocs.py (-rw-r--r-- root:root)
 FILES:+usr/lib/python3.11/site-packages/fract4d/createdocs.py (-rwxr-xr-x root:root)
 FILES:-usr/lib/python3.11/site-packages/fract4d_compiler/fc.py (-rw-r--r-- root:root)
 FILES:+usr/lib/python3.11/site-packages/fract4d_compiler/fc.py (-rwxr-xr-x root:root)
 FILES:-usr/lib/python3.11/site-packages/fract4d_compiler/fractlexer.py (-rw-r--r-- root:root)
 FILES:-usr/lib/python3.11/site-packages/fract4d_compiler/fractparser.py (-rw-r--r-- root:root)
 FILES:+usr/lib/python3.11/site-packages/fract4d_compiler/fractlexer.py (-rwxr-xr-x root:root)
 FILES:+usr/lib/python3.11/site-packages/fract4d_compiler/fractparser.py (-rwxr-xr-x root:root)
 FILES:-usr/lib/python3.11/site-packages/fract4d_compiler/translate.py (-rw-r--r-- root:root)
 FILES:+usr/lib/python3.11/site-packages/fract4d_compiler/translate.py (-rwxr-xr-x root:root)

@cjmayo
Ensure installed modules are not executable
78f9b2a 
Match the permissions that were being applied by setuptools.
@cjmayo cjmayo mentioned this pull request Apr 26, 2024
Closed
dragonmux
dragonmux approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean and simple fix! Feel free to merge when ready.

@cjmayo cjmayo merged commit 0caa3dc into fract4d:master Apr 29, 2024
5 of 6 checks passed
@cjmayo cjmayo deleted the install-mode branch April 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjmayo @dragonmux