Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions instead of Travis #142

Merged
merged 7 commits into from
Jul 1, 2020
Merged

Conversation

cjmayo
Copy link
Collaborator

@cjmayo cjmayo commented Jun 22, 2020

With all the problems with Travis here is an attempt to use GitHub actions instead. Let's see if the PR works. One advantage - it is easier to re-run when there is a segfault...

It does clash with #141. So, would need to be updated.

@mindhells
Copy link
Member

Never used them but looks great.
Maybe we could add the OS into the matrix and include macos as a supporting OS as well as ubuntu. I would rather use specific versions though: ubuntu-18.04 and macos-10.15
Artifacts sound promising too for building binary releases with pyoxidizer (as @edyoung suggested in #133).

@cjmayo
Copy link
Collaborator Author

cjmayo commented Jun 24, 2020

Added upload to Codecov (it can take the XML report from pytest-cov, unlike Coveralls).

Added a MacOS job for Python 3.7.

Being specific about OS versions would be my first idea, but here I'm not so sure, it creates maintenance work. On the other hand if we are saying we are supporting specific OS versions then that would be useful.

@dragonmux
Copy link
Member

You can matrix on the OS versions as well as Python and have -latest and specific versions so you get to see if anything broke in the newest of the OS and set up support guarantees for the rest

@edyoung
Copy link
Member

edyoung commented Jun 28, 2020

I'm all for it

@cjmayo
Copy link
Collaborator Author

cjmayo commented Jun 29, 2020

Rebased on master to fix clashes and changed to specific OS's with the objective of trying everything at least once (will Ubuntu 20.04 work???).

@cjmayo
Copy link
Collaborator Author

cjmayo commented Jun 29, 2020

I'm all for it

Great! Can you enable Actions for the repository under Settings/Actions?

@edyoung
Copy link
Member

edyoung commented Jun 30, 2020

Already enabled as as far as I can see

image

@cjmayo cjmayo marked this pull request as ready for review June 30, 2020 18:25
@cjmayo
Copy link
Collaborator Author

cjmayo commented Jun 30, 2020

Thanks for checking. I have now pushed this PR as a branch to the repository and the actions started running. Also realised another commit was needed to stop trying to upload to Codecov from the Pylint job.

@dragonmux dragonmux merged commit c09ff73 into fract4d:master Jul 1, 2020
@cjmayo cjmayo deleted the actions branch July 1, 2020 18:34
@edyoung
Copy link
Member

edyoung commented Jul 3, 2020

Thanks! Looks great

@mindhells
Copy link
Member

mindhells commented Jul 6, 2020

should .travis.yml file be removed?

sorry for late reply, but I've just realized that in the fork I'm using, travis is still enabled but it fails because it tries to run tests for python 3.5 which support has been dropped recently.

@dragonmux
Copy link
Member

Seeing we can re-create the config if we want to try fixing and re-enabling Travis at some later date, I see no harm in removing the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants