Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused variable and extra ‘;’ warnings #134

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Fix unused variable and extra ‘;’ warnings #134

merged 1 commit into from
Jun 13, 2020

Conversation

cjmayo
Copy link
Collaborator

@cjmayo cjmayo commented Jun 12, 2020

Please check - I'm just following the compiler messages.

@dragonmux
Copy link
Member

dragonmux commented Jun 12, 2020 •
edited
Loading

Changes look good - the warnings should indeed be heeded.. I'd suggest enabling -Wall -Wextra -pedantic and see what falls out as I expect those aren't the only warnings that need looking at

@edyoung edyoung merged commit 3646cc9 into fract4d:master Jun 13, 2020
@cjmayo cjmayo deleted the warnings branch June 13, 2020 16:53
@mindhells
Copy link
Member

Changes look good - the warnings should indeed be heeded.. I'd suggest enabling -Wall -Wextra -pedantic and see what falls out as I expect those aren't the only warnings that need looking at

I'm planning to try clang-tidy as @edyoung suggested in #119 . That should help.

@mindhells mindhells mentioned this pull request Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edyoung edyoung edyoung approved these changes

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjmayo @dragonmux @mindhells @edyoung