Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting point for a benchmark to compare multiple-precision libs #112

Merged
merged 9 commits into from
May 31, 2020

Conversation

edyoung
Copy link
Member

@edyoung edyoung commented May 23, 2020

Uses Google benchmark library. Need to rearrange the docker stuff, it recompiles the benchmark library every time which slows things down a lot.

Run the benchmark with examples/cpp/mp_benchmark.sh

Sample output:

Running ./example
Run on (4 X 2700 MHz CPU s)
CPU Caches:
  L1 Data 32 KiB (x2)
  L1 Instruction 32 KiB (x2)
  L2 Unified 256 KiB (x2)
  L3 Unified 3072 KiB (x1)
Load Average: 2.38, 1.75, 1.11
***WARNING*** CPU scaling is enabled, the benchmark real time measurements may be noisy and will incur extra overhead.
***WARNING*** Library was built as DEBUG. Timings may be affected.
----------------------------------------------------------------------
Benchmark                            Time             CPU   Iterations
----------------------------------------------------------------------
BM_fractal/min_time:120.000       6823 ms         6823 ms           25

@edyoung edyoung requested a review from mindhells May 23, 2020 23:46
Copy link
Member

@mindhells mindhells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool.
I've created #113 to update this branch:

  • preventing the benchmark library to be recompiled every time
  • update the examples readme

@mindhells
Copy link
Member

bringing Boost into the project opens a world of possibilities, like:
https://github.com/boostorg/compute (in regard to #78)

@dragonmux
Copy link
Member

dragonmux commented May 30, 2020

I will warn that it can also severely complicate things - particularly when trying to get the project to build on a RHEL or SLES box because they invariably have very old Boost's and not installed by default even when you put the compilers on..

But as long as that's a trade-off you're willing to make, it is an intriguing idea

@edyoung edyoung merged commit 70ef79d into master May 31, 2020
edyoung added a commit that referenced this pull request Jun 7, 2020
* work in progress: create markdown-based manual

* finished first pass through manual.md

* exclude parsetab and lextab from pylint (#102)

* Remove buildtools package (#104)

No executable files ending in get.py are being installed.

* Add pylint singleton-comparison check (#105)

* Remove unused traceback import (#106)

* fix #107: wait until fd has something to read or fail (#108)

* Arbitrary precision formula experiment (#103)

* examples: allow custom formula filename in cmake

* [#7] example experiment: formula with arbitrary precision support

* MP example: add swap idiom and other improvements

* add debug information to cpp examples compilation

* release prep for 4.2 (#111)

* Update http links in README.md and setup.py to https (#115)

* Starting point for a benchmark to compare multiple-precision libs (#112)

* typo

* experiment to benchmark arbitrary precision math

* was running 3 benchmarks

* update #112 (#113)

* install google benchmark globally in exmaples infrastructure

* update exmaples readme

* disable frequency scaling during benchmark

* remove i/o from benchmark loop

* benchmark several different bit lengths

* Basis for discussion on available math libraries

* notes

Co-authored-by: Alberto Gonzalez <[email protected]>

* tweak doc generation process

* Check gnofract4d executable with pylint (#117)

* Install icons into the hicolor theme (#121)

gnofract4d-logo.png is size 640x640.

Individual icons created using ImageMagick, e.g.:
magick gnofract4d-logo.png -strip -resize 256x256 logo/256x256/gnofract4d.png

Install the 48x48 icon into pixmaps.

* Run pylint as a separate job (#118)

Report linting and testing results separately. Only run pylint once.

* C++ Engine refactor (#116)

* tidy worker initialization

* remove unused typedef

* worker: improve AA comparison

* fix docker test script

* remove duplicate extern declaration

* workers: refactor common members into base

* remove some completed todo's

* organize fractfunc initialization and members

* unravel coupling: pointfunc - site

* refactor: extract calculation options into a struct to ease initializers

* remove duplicate

* move rgba type basic operations to its type definition

* remove some temporaries in stworker->work

* review worker member names

* remove unneeded worker alloc members

* remove pointFunc factory

* update some old-fashion idioms on fractfunc and stats

* prefix fractfunc private members

* avoid clearing fates twice when autoupdating iters and period tolerance

* reorganize and narrow down public/private worker interface

* remove unused, mark experimental and review old fashioned code on stfractworker

* calcoptions: add some comments and move asynchronous back to where it belongs

* prevent uninitialized members on fractFunc

* remove initialization success flag on workers

* fix comment

* reorganize fractfunct members and remove unused

* work in progress: create markdown-based manual

* finished first pass through manual.md

* tweak doc generation process

* generate manual with hugo

new directory 'manual' generates standalone HTML for manual

* rest of hugo-based manual

* repoint to our copy of theme

* repoint to our version of theme

* install hugo-generated manual

* update submodule ref

* ignorance

* delete docbook version of manual. so long!

* fix test for doc version

* fix submodule commit

* install hugo in travis

* better errors on doc generation

* more debug output

* jfc

* apt version of hugo is too old, try this

* maybe this

* fold createdocs into setup

* delete old files

* work in progress: create markdown-based manual

* finished first pass through manual.md

* tweak doc generation process

* work in progress: create markdown-based manual

* generate manual with hugo

new directory 'manual' generates standalone HTML for manual

* rest of hugo-based manual

* repoint to our copy of theme

* repoint to our version of theme

* install hugo-generated manual

* update submodule ref

* ignorance

* delete docbook version of manual. so long!

* fix test for doc version

* fix submodule commit

* install hugo in travis

* better errors on doc generation

* more debug output

* jfc

* apt version of hugo is too old, try this

* maybe this

* fold createdocs into setup

* delete old files

* delete gui createdocs

It's more trouble than it is worth.
Getting access violations when calling it from setup.py.
Since this doesn't change much anyway,
easier to maintain commands.html manually

* setup.py updates

distutils to setuptools
make doc generation a custom build step

* merge madness

* build manual first

* custom build command doesn't work :-(

* back to generating docs separately

* checkin generated doc files for consistency

* restore css file

* move css file inside fract4dgui

* fix finding resources after install

* guess which pylint to use

* typo

* disable that darn test

* fix pylint whining

Co-authored-by: Alberto Gonzalez <[email protected]>
Co-authored-by: Chris Mayo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants