Merged
Conversation
This was referenced Oct 2, 2023
Contributor
Author
|
See sagemath/sage#36407 (comment) for an explanation of the change. |
Collaborator
|
Thank you so much for this, could you rebase your PR on the current master branch, it should resolve those CI failures. |
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The necessary functions are copied from cpython 3.12
Include/internal/pycore_long.h, which is private. This should make it easy to copy new versions if cpython internals change. For cpython < 3.12 I implemented equivalent functions.All of this is placed in separate files
pycore_long.pxdandpycore_long.hcopied from sagemath/cypari2#137.Tested in 64-bit and 32-bit x86.
Fixes: #246