Revert "fix(core): use rglob to guess local Python modules (#753)"
#798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0820845.
mkniewallner
force-pushed
the
revert-753-fix/issue-740
branch
from
5fb4131
to
087b8af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
=====================================
Coverage 93.0% 93.0%
=====================================
Files 37 37
Lines 961 961
Branches 173 173
=====================================
Hits 894 894
Misses 51 51
Partials 16 16 ☔ View full report in Codecov by Sentry. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #797.
Reverts #753, that was meant to resolve #740, but did not fully resolve the issue in the end. Since the change introduces a significant performance regression in huge codebases, it feels better to revert the change for the moment, and see how we can properly support PEP 420, while limiting the impact on performance.