Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce both opentelemetry 0.26 and 0.27 exporter #793

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 25, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. Found a better to make different exporter dependency version live together.

close #792

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #792

@MrCroxx MrCroxx added feature New feature or request refactor labels Nov 25, 2024
@MrCroxx MrCroxx added this to the v0.13 milestone Nov 25, 2024
@MrCroxx MrCroxx self-assigned this Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-common/src/metrics/model.rs 100.00% <100.00%> (ø)
...-common/src/metrics/registry/opentelemetry_0_26.rs 100.00% <100.00%> (ø)
...-common/src/metrics/registry/opentelemetry_0_27.rs 100.00% <ø> (ø)

🚨 Try these New Features:

@MrCroxx MrCroxx merged commit fd2bed4 into main Nov 25, 2024
23 checks passed
@MrCroxx MrCroxx deleted the xx/mmetrics branch November 25, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

refactor: decouple metrics exporters with foyer
1 participant