Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wrapper no/immutable/mutable op into Op #788

Merged
merged 1 commit into from
Nov 19, 2024
Merged

refactor: wrapper no/immutable/mutable op into Op #788

merged 1 commit into from
Nov 19, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 19, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

@MrCroxx MrCroxx added this to the v0.13 milestone Nov 19, 2024
@MrCroxx MrCroxx self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 87.20000% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-memory/src/eviction/test_utils.rs 60.00% 8 Missing ⚠️
foyer-memory/src/eviction/lfu.rs 83.78% 6 Missing ⚠️
foyer-memory/src/eviction/lru.rs 97.22% 1 Missing ⚠️
foyer-memory/src/raw.rs 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-memory/src/eviction/fifo.rs 90.80% <100.00%> (+7.64%) ⬆️
foyer-memory/src/eviction/mod.rs 100.00% <100.00%> (ø)
foyer-memory/src/eviction/s3fifo.rs 88.77% <100.00%> (+1.78%) ⬆️
foyer-memory/src/eviction/lru.rs 91.64% <97.22%> (+1.02%) ⬆️
foyer-memory/src/raw.rs 91.04% <75.00%> (+0.28%) ⬆️
foyer-memory/src/eviction/lfu.rs 85.40% <83.78%> (+1.36%) ⬆️
foyer-memory/src/eviction/test_utils.rs 74.19% <60.00%> (-25.81%) ⬇️

🚨 Try these New Features:

@MrCroxx MrCroxx merged commit f9ac2f9 into main Nov 19, 2024
23 checks passed
@MrCroxx MrCroxx deleted the xx/op branch November 19, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant