Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix panic on scanner overflow #677

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: fix panic on scanner overflow #677

merged 2 commits into from
Aug 29, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Aug 29, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

  • Fix panic on scanner overflow.
  • Rename CachedDeviceReader as CachedRegionReader.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

fix #676

@MrCroxx MrCroxx added the bug Something isn't working label Aug 29, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Aug 29, 2024
@MrCroxx MrCroxx self-assigned this Aug 29, 2024
@MrCroxx MrCroxx mentioned this pull request Aug 29, 2024
Signed-off-by: MrCroxx <[email protected]>
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-storage/src/error.rs 0.00% <ø> (ø)
foyer-storage/src/large/scanner.rs 75.72% <100.00%> (+7.06%) ⬆️
foyer-storage/src/region.rs 90.60% <100.00%> (+0.15%) ⬆️

... and 2 files with indirect coverage changes

@MrCroxx MrCroxx merged commit 7eeb783 into main Aug 29, 2024
18 checks passed
@MrCroxx MrCroxx deleted the xx/fscan branch August 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: scanner panic on overflow
1 participant