Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dedicated cleaner thread for in-memory cache #654

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Aug 19, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

TODO: WIP

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#653

@MrCroxx MrCroxx added feature New feature or request perf Performance optimization labels Aug 19, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Aug 19, 2024
@MrCroxx MrCroxx self-assigned this Aug 19, 2024
Signed-off-by: MrCroxx <[email protected]>
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 16.98113% with 44 lines in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (aab45f0) to head (b188bd0).

Files Patch % Lines
foyer-memory/src/cleaner.rs 0.00% 27 Missing ⚠️
foyer/src/hybrid/builder.rs 0.00% 8 Missing ⚠️
foyer-memory/src/cache.rs 22.22% 7 Missing ⚠️
foyer-bench/src/main.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   82.66%   82.22%   -0.44%     
==========================================
  Files          66       67       +1     
  Lines        8115     8164      +49     
==========================================
+ Hits         6708     6713       +5     
- Misses       1407     1451      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx modified the milestones: v0.11, v0.12 Aug 21, 2024
@MrCroxx MrCroxx modified the milestones: v0.12, Planning Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request perf Performance optimization
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant