Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce compact bloom filter #612

Merged
merged 3 commits into from
Jul 15, 2024
Merged

feat: introduce compact bloom filter #612

merged 3 commits into from
Jul 15, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jul 11, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#596

@MrCroxx MrCroxx added the feature New feature or request label Jul 11, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Jul 11, 2024
@MrCroxx MrCroxx self-assigned this Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 91.26214% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.06%. Comparing base (fb8144f) to head (3e96d81).

Files Patch % Lines
foyer-common/src/compact_bloom_filter.rs 91.26% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   81.95%   82.06%   +0.11%     
==========================================
  Files          63       64       +1     
  Lines        8112     8215     +103     
==========================================
+ Hits         6648     6742      +94     
- Misses       1464     1473       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit e6a7fda into main Jul 15, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/cbf branch July 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant