Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine either storage #609

Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat: refine either storage #609

merged 2 commits into from
Jul 10, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jul 10, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

This PR refined the implementation of Either and Selector to make them behave.

Changes:

  • Refined Either and Selector.
  • Replace EnqueueHandle with WaitHandle with more flexibilities.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#596

@MrCroxx MrCroxx added feature New feature or request refactor labels Jul 10, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Jul 10, 2024
@MrCroxx MrCroxx self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 33.64486% with 71 lines in your changes missing coverage. Please review.

Project coverage is 82.43%. Comparing base (3c15f70) to head (58e58ac).

Files Patch % Lines
foyer-storage/src/storage/either.rs 0.00% 35 Missing ⚠️
foyer-storage/src/engine.rs 26.47% 25 Missing ⚠️
foyer-storage/src/small/generic.rs 0.00% 9 Missing ⚠️
foyer-storage/src/large/generic.rs 88.88% 1 Missing ⚠️
foyer-storage/src/storage/runtime.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   82.72%   82.43%   -0.30%     
==========================================
  Files          62       62              
  Lines        8016     8037      +21     
==========================================
- Hits         6631     6625       -6     
- Misses       1385     1412      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx merged commit 034032f into main Jul 10, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/either branch July 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant