Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: combined disk cache framework (p2) #605

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: combined disk cache framework (p2) #605

merged 1 commit into from
Jul 9, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jul 9, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

This PR is the second part to implement the combined (large + small) disk cache.

Changes:

  • Introduced Device enum, renamed the original Device to Dev.
  • Refined the combined disk cache framework.
  • Removed generic type Dev from most of the types.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#596

@MrCroxx MrCroxx added feature New feature or request refactor labels Jul 9, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Jul 9, 2024
@MrCroxx MrCroxx self-assigned this Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 50.57143% with 173 lines in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (37fd364) to head (4015c70).

Files Patch % Lines
foyer-storage/src/store.rs 39.85% 83 Missing ⚠️
foyer-storage/src/engine.rs 23.46% 75 Missing ⚠️
foyer-storage/src/device/mod.rs 65.85% 14 Missing ⚠️
foyer-storage/src/large/generic.rs 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   83.66%   82.79%   -0.87%     
==========================================
  Files          62       62              
  Lines        7843     7976     +133     
==========================================
+ Hits         6562     6604      +42     
- Misses       1281     1372      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit 515eb87 into main Jul 9, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/small2 branch July 9, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant