Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate store and storage abstraction #602

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jul 9, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

The PR separates the Store and the Storage abstraction.

It is the first step to support both large object store and the small object store.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#596

@MrCroxx MrCroxx added this to the v0.11 milestone Jul 9, 2024
@MrCroxx MrCroxx self-assigned this Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (fa517db) to head (4955d36).

Files Patch % Lines
foyer-storage/src/picker/utils.rs 55.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   85.85%   85.78%   -0.07%     
==========================================
  Files          59       59              
  Lines        7577     7583       +6     
==========================================
  Hits         6505     6505              
- Misses       1072     1078       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit ca166c6 into main Jul 9, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/storage branch July 9, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant