Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: region advance & recovery & seal #53

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix: region advance & recovery & seal #53

merged 1 commit into from
Jul 6, 2023

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jul 6, 2023

Signed-off-by: MrCroxx [email protected]

  • fix region advance
  • fix recovery slice destroy
  • seal last dirty region when shutdown

close: #33

- fix region advance
- fix recovery slice destroy
- seal last dirty region when shutdown

Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx added the bug Something isn't working label Jul 6, 2023
@MrCroxx MrCroxx self-assigned this Jul 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #53 (ccb5c68) into main (011a401) will increase coverage by 26.11%.
The diff coverage is 93.75%.

@@             Coverage Diff             @@
##             main      #53       +/-   ##
===========================================
+ Coverage   41.13%   67.24%   +26.11%     
===========================================
  Files          30       30               
  Lines        3428     3520       +92     
===========================================
+ Hits         1410     2367      +957     
+ Misses       2018     1153      -865     
Impacted Files Coverage Δ
foyer-intrusive/src/eviction/fifo.rs 98.35% <ø> (+9.89%) ⬆️
foyer-storage/src/flusher.rs 82.69% <ø> (+82.69%) ⬆️
foyer-storage/src/reclaimer.rs 84.34% <ø> (+84.34%) ⬆️
foyer-storage/src/store.rs 90.49% <93.61%> (+90.49%) ⬆️
foyer-storage/src/region.rs 68.53% <100.00%> (+68.53%) ⬆️
foyer-storage/src/region_manager.rs 91.07% <100.00%> (+91.07%) ⬆️

... and 11 files with indirect coverage changes

@MrCroxx MrCroxx merged commit e61eb5d into main Jul 6, 2023
@MrCroxx MrCroxx deleted the xx/fix/recovery branch July 6, 2023 05:27
MrCroxx added a commit that referenced this pull request Apr 17, 2024
- fix region advance
- fix recovery slice destroy
- seal last dirty region when shutdown

Signed-off-by: MrCroxx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug: flush half-dirty region while closing store
2 participants