Use single TextEncoder/-Decoder instance #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
changed the title
defunctzombie
approved these changes
Dec 29, 2023
|
A new CdrReader instance is created for every message: https://github.com/foxglove/rosmsg2-serialization/blob/main/src/MessageReader.ts#L43-L46 However, I don't think that this will make a very noticeable performance difference (I didn't measure it) |
jtbandes
approved these changes
Dec 30, 2023
This was referenced Jan 2, 2024
Merged
achim-k
added a commit
to foxglove/omgidl
that referenced
this pull request
Jan 8, 2024
### Public-Facing Changes None ### Description Bumps `@foxglove/cdr` to 3.2.1 to include foxglove/cdr#22 @snosenzo probably makes sense to add a dependabot configuration file to this repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
None
Description
Instead of creating a new TextDecoder instance for every CdrReader instance, a single TextDecoder instance is used to reduce unnecessary GC cycles. The same is done for TextEncoder / CdrWriter.