Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the target.remote.force-ipv4 option #442

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

delthas
Copy link
Contributor

@delthas delthas commented Jan 8, 2022

No description provided.

@delthas delthas force-pushed the feature-force-ipv4 branch from 132b4cf to 9fd2eb5 Compare January 8, 2022 16:00
@delthas delthas marked this pull request as ready for review January 8, 2022 16:04
@delthas
Copy link
Contributor Author

delthas commented Jan 8, 2022

Tested locally on my maddy instance.

@codecov-commenter
Copy link

Codecov Report

Merging #442 (9fd2eb5) into master (5536895) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   54.18%   54.18%   -0.01%     
==========================================
  Files         123      123              
  Lines       10327    10334       +7     
==========================================
+ Hits         5596     5599       +3     
- Misses       4102     4106       +4     
  Partials      629      629              
Flag Coverage Δ
integration 34.99% <14.28%> (-0.02%) ⬇️
unit 55.21% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/target/remote/remote.go 70.16% <14.28%> (-1.63%) ⬇️
internal/target/queue/timewheel.go 96.77% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc6cb1d...9fd2eb5. Read the comment docs.

@foxcpp foxcpp merged commit 5972749 into foxcpp:master Jan 9, 2022
@foxcpp
Copy link
Owner

foxcpp commented Jan 9, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants