Repository navigation
fix(streaming): refresh substitution #1 anchor for v0.51.145 - #448
Merged
Merged
Conversation
The streaming patch's local-fallback plumbing anchor expected a dict closing brace `}` before "Build kwargs defensively", but upstream v0.51.145 refactored fallback resolution to end with `_fallback_resolved = _fallback_chain or None` instead. The stale anchor caused 3 test failures + 3 errors in CI's validate-overlay (which runs with hermes-webui on PYTHONPATH). Local tests were unaffected because `api` is not importable without PYTHONPATH, so bootstrap caught ImportError before reaching the AssertionError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
}before "Build kwargs defensively" but v0.51.145 has_fallback_resolved = _fallback_chain or Nonethere insteadapimodule isn't importable without PYTHONPATH — bootstrap caught ImportError before reaching AssertionErrorTest plan
check-overlay-basis.shcleanwebui_patches.apply_all()succeeds against real upstream source