Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sncast account commands print the address with incorrect length #2424

Closed
1 task
ggonzalez94 opened this issue Aug 29, 2024 · 0 comments · Fixed by #2486
Closed
1 task

sncast account commands print the address with incorrect length #2424

ggonzalez94 opened this issue Aug 29, 2024 · 0 comments · Fixed by #2486
Assignees
Labels
bug Something isn't working sncast

Comments

@ggonzalez94
Copy link

Which component is your bug related to?

sncast

Foundry Version

0.28.0

What operating system are you using?

MacOS

What system architecture are you using?

x86

What happened

All sncast account commands I tried print the address with 63 characters after 0x. There should be 64 characters(32 bytes). Accounts are missing a zero after 0x. This is a simple error, but can make people that are unaware loose time since pasting this address on block explorers or faucets gives you an error about the address being invalid.

Trace

Output of sncast account create on Sepolia

command: account create
add_profile: --add-profile flag was not set. No profile added to snfoundry.toml
address: 0x56dda3be03ae9013f6c6cafaede2834c524018164a6a42218c288aa544eeb8e
max_fee: 6048364968880
message: Account successfully created. Prefund generated address with at least <max_fee> STRK tokens or an equivalent amount of ETH tokens. It is good to send more in the case of higher demand.

Is there an existing issue for this?

  • I have searched the existing issues and verified no issue exits for this problem.
@ggonzalez94 ggonzalez94 added the bug Something isn't working label Aug 29, 2024
@github-actions github-actions bot added the new label Aug 29, 2024
@cptartur cptartur removed the new label Sep 18, 2024
@cptartur cptartur moved this from New to Backlog in Starknet foundry Sep 18, 2024
@cptartur cptartur self-assigned this Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2024
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2248 
Closes #2424 

## Introduced changes

<!-- A brief description of the changes -->

- Addresses used in `sncast account create`, `sncast declare` and
`sncast deploy` are now correctly padded to 66 (64 after `0x`)
characters length.

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: ddoktorski <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sncast
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants