fix(evm-adapters) remove checkTopic error from expectEmit in testFailExpectEmitWithCall1 and testFailExpectEmitWithCall2#925
Conversation
Member
|
@brockelmore i am not sure that this PR makes the test tighter actually? |
Member
|
this is checked in the fuzztests for expectemit in https://github.com/gakonst/foundry/pull/965, closing - thanks for the contribution either way @bblanc42! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The function
testFailExpectEmitWithCall1is supposed to fail due to "data is different." However, the test is failing due to two reasons, which arecheckTopic3isfalseIn other words, even if the data is the same as emitted by
t4(), i.e.,emit Transfer(address(this), address(1338), 100 gwei);the test will also fail. Hence, it is best to let this test to only fail due to "data is different."Solution
emit Transfer(address(this), address(1337), 1 gwei);will fail only due to "data is different"