feat: implement parseTomlType cheats#8911
Merged
klkvr merged 5 commits intofoundry-rs:masterfrom Sep 20, 2024
Merged
Conversation
zerosnacks
reviewed
Sep 20, 2024
Member
zerosnacks
left a comment
zerosnacks
left a comment
There was a problem hiding this comment.
Thanks this is great!
Minor feedback in regards to naming change in test
zerosnacks
approved these changes
Sep 20, 2024
Member
|
PTAL @klkvr |
klkvr
approved these changes
Sep 20, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Sep 25, 2024
* feat: implement `parseTomlType` cheats * chore: `forge fmt` * revert: use json naming to indicate to users that they are operating on json data * chore: nit * chore: nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #8810
Solution
Mostly a copy/paste of #8345.
Minor: removal of references of
jsonintestdata/default/cheats/Toml.t.soland use oftomlinstead.