Conversation
mattsse
approved these changes
Sep 17, 2024
Member
Author
|
Regressed in #8238 My original thinking was that it didn't matter that much for perf, which I still think it's true, might be 10-20% faster; but it definitely matters for binary size which I did not consider, as can be seen by the size difference of the tarballs in june vs july nightlies: |
Member
Author
|
Should help with #8671 |
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oops