refactor: use TransactionRequest everywhere#7040
Merged
Conversation
Evalir
commented
Feb 7, 2024
3 tasks
onbjerg
approved these changes
Feb 8, 2024
Member
Author
|
@onbjerg ci won't pass until we merge the main pr—the evm-inspectors crate uses the normal rpc types instead of the ones pointing to your branch |
Member
|
@Evalir main PR is merged, can you update this PR? |
onbjerg
approved these changes
Feb 9, 2024
Member
Author
|
ci seems hanged up? |
Member
|
we dont have unlimited runners so sometimes other prs need to finish before ci can run |
Member
Author
|
doesn't seem like there's any pr running though |
Evalir
force-pushed
the
evalir/dedupe-tx-request-anvil
branch
from
0887695 to
001d02a
Compare
Member
Author
|
needs alloy-rs/alloy#195 |
Member
Author
|
ci failure unrelated. |
This was referenced Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously we were using
CallRequest, and an in-houseTransactionRequest.Solution
Switches to using
TransactionRequesteverywhere.Depends on alloy-rs/alloy#178