[forge] verify-contract: support --via-ir flag #6781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
force-pushed
the
michael/verify-via-ir
branch
from
9ee4d75
to
1370aff
Compare
DaniPopes
approved these changes
Jan 18, 2024
|
Note that this does only adds it to the local structs, it's not sent off to etherscan |
|
Sorry but is this even right? I don't see anything referencing "viaIR" in the etherscan docs https://docs.etherscan.io/api-endpoints/contracts |
|
Nevermind apparently it does exist, just completely undocumented 👍 |
kevincheng96
added a commit
to compound-finance/quark
that referenced
this pull request
Feb 8, 2024
Deploys the latest version of Quark contracts to Goerli. Looks like the contracts built using `via-ir` also now verify after the latest Foundry [fix](foundry-rs/foundry#6781). ``` ============================================================= Deploying Quark Factory Quark Factory Deployed: 0x6aDEB6d973980cb4093882EE57b75c251b4d6af0 Deploying Quark Contracts via Quark Factory Code Jar Deployed: 0x6385C1d72862D10FD77CEB80C1b896E030Fa8Cce Quark State Manager Deployed: 0x57AEAA002075971027C9cD72a86eD1c3D864D80e Quark Wallet Implementation Deployed: 0x9EEcB6F3C9b7516094ed78e2E0E76201cbd6aAC0 Quark Wallet Proxy Factory Deployed: 0x9D8ec03E9DDB71f04DA9db1E38837Aaac1782a97 Batch Executor Deployed: 0x8BD4C901582460B77aDABcdb00438959071a5567 Deploying Core Scripts Ethcall Deployed: 0x3F289a2BaB7eAbD7C381FEaF51729e22f6d7a2Df Multicall Deployed: 0xE240f7A45b6A1DE13a2cd5810c13A32AaFD35Fa9 ============================================================= ```
This was referenced Apr 26, 2024
gosuto-inzasheru
added a commit
to gosuto-inzasheru/book
that referenced
this pull request
Jul 13, 2024
documenting changes added by foundry-rs/foundry#6781
mattsse
pushed a commit
to foundry-rs/book
that referenced
this pull request
Jul 13, 2024
documenting changes added by foundry-rs/foundry#6781
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When you
forge create --via-ir, you cannot verify later withforge verify-contract, which does not support the--via-irflag.Solution
Introduces a
--via-irflag intoverify-contractwhich causes the standard json-input passed to etherscan to include"viaIR":true, which fixes verification.Fixes the original problem in #3507, although that issue seems to have evolved to include #6780.