Skip to content

fix(common): include ws and ipc features#5787

Merged
mattsse merged 1 commit intofoundry-rs:masterfrom
bernard-wagner:fix-ws-ipc
Sep 6, 2023
Merged

fix(common): include ws and ipc features#5787
mattsse merged 1 commit intofoundry-rs:masterfrom
bernard-wagner:fix-ws-ipc

Conversation

@bernard-wagner
Copy link
Contributor

@bernard-wagner bernard-wagner commented Sep 6, 2023

Motivation

#5783

#5571 broke installing binaries using cargo due to workspace features being missing.

Solution

Ensure the correct features are included in the cargo.toml.

Test

cargo install --git https://github.com/bernard-wagner/foundry --branch fix-ws-ipc --profile local forge cast chisel anvil

@bernard-wagner bernard-wagner marked this pull request as ready for review September 6, 2023 09:26
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm—just need to fix the test fixtures

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse merged commit 675a824 into foundry-rs:master Sep 6, 2023
mikelodder7 pushed a commit to LIT-Protocol/foundry that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants