chore(cheatcodes): clean up cheatcodes util.rs with new wallet and parsing#5758
Merged
chore(cheatcodes): clean up cheatcodes util.rs with new wallet and parsing#5758
cheatcodes): clean up cheatcodes util.rs with new wallet and parsing#5758Conversation
Evalir
force-pushed
the
evalir/move-derive-cheats
branch
from
5c173f9 to
c3f9464
Compare
mattsse
approved these changes
Aug 31, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this is better.
smol nit re file name
mikelodder7
pushed a commit
to LIT-Protocol/foundry
that referenced
this pull request
Sep 12, 2023
…and `parsing` (foundry-rs#5758) * feat: add new wallet/parsing files with respective funcs * chore: dedupe * chore: re-use new cheatcodes * chore: move skip to ext * fmt * chore: parsing -> parse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While preparing part of the alloy migration i noticed cheatcodes/util.rs kind of became a dumpster for cheatcodes we didn't really know where to place along with totally unrelated funcs. This makes utils actually an utils file.
Solution
reorg into
walletandparsing:walletcontains all the wallet/signing cheatcodes from util, whileparsingcontains the utility parsing cheatcodes.skipwas moved intoext.