Merged
Conversation
59d45da to
4d64799
Compare
Evalir
reviewed
Aug 18, 2023
Member
huge fan
Yeah i think it ended up being useless. We ideally wanted it as a cache step but it didn't really help at all due to the ci structure
Yeah might be slower, but hopefully it should be OK if the runtime is still less than an hour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make CI better
Solution
external-integration-testsfeature, since we can just filter better instead of having to recompileinstall-svm-solcjob--release. This might be slower