chore(cli): split forge, cast CLI args into separate modules#5596
Merged
mattsse merged 3 commits intofoundry-rs:masterfrom Aug 11, 2023
Merged
chore(cli): split forge, cast CLI args into separate modules#5596mattsse merged 3 commits intofoundry-rs:masterfrom
mattsse merged 3 commits intofoundry-rs:masterfrom
Conversation
Evalir
approved these changes
Aug 11, 2023
mattsse
requested changes
Aug 11, 2023
Member
mattsse
left a comment
There was a problem hiding this comment.
I love this,
unfortunately, this also needs a rebase
1080011 to
064eac5
Compare
Member
Author
|
Re Based |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce compilation times and binary bloat.
Isolate forge and cast CLI args from each other since they do not share almost any code. (7e8ebdc)
The code they do share is extracted into foundry-cli. This is just
CoreBuildArgsandProjectPathsArgsfromcmd::forge::build. (539f9d0)Before:
After: