Clarifies readme regarding ignored env variables#5591
Merged
Evalir merged 2 commits intofoundry-rs:masterfrom Aug 10, 2023
Merged
Clarifies readme regarding ignored env variables#5591Evalir merged 2 commits intofoundry-rs:masterfrom
Evalir merged 2 commits intofoundry-rs:masterfrom
Conversation
DaniPopes
reviewed
Aug 10, 2023
config/README.md
Outdated
| corresponding [dapptools](https://github.com/dapphub/dapptools/tree/master/src/dapp#configuration) config vars are also | ||
| supported, this means that `FOUNDRY_SRC` and `DAPP_SRC` are equivalent. | ||
|
|
||
| Some exceptions to the above are [explicitly ignored](https://github.com/foundry-rs/foundry/blob/master/config/src/lib.rs#L1539-L1552) due to security concerns. |
Member
There was a problem hiding this comment.
Can we make this a perma link?
https://github.com/foundry-rs/foundry/blob/10440422e63aae660104e079dfccd5b0ae5fd720/config/src/lib.rs#L1539-L1552
DaniPopes
pushed a commit
to DaniPopes/foundry
that referenced
this pull request
Aug 11, 2023
* Clarifies readme regarding ignored env variables * chore: make permalink --------- Co-authored-by: Enrique Ortiz <hi@enriqueortiz.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some env variables are explicitly ignored, but the README suggests they all should work