feat(forge): Add --priority-gas-price argument for forge script#5585
Merged
mattsse merged 1 commit intofoundry-rs:masterfrom Aug 10, 2023
Merged
feat(forge): Add --priority-gas-price argument for forge script#5585mattsse merged 1 commit intofoundry-rs:masterfrom
--priority-gas-price argument for forge script#5585mattsse merged 1 commit intofoundry-rs:masterfrom
Conversation
mattsse
approved these changes
Aug 10, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm,
merging+releasing this now, with followup improvements for L2
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the estimated
ETH_PRIORITY_GAS_PRICEused byforge scriptis unnecessarily large on L2's such as Optimism and Arbitrum. Resolves #5281Solution
This PR adds an argument to manually set the priority gas price for forge script and uses that price if it is provided.
Additional context