fix(remappings): properly filter only autodetected remappings, do not sort unnecesarily#5562
Merged
fix(remappings): properly filter only autodetected remappings, do not sort unnecesarily#5562
remappings): properly filter only autodetected remappings, do not sort unnecesarily#5562Conversation
mattsse
requested changes
Aug 8, 2023
Member
mattsse
left a comment
There was a problem hiding this comment.
few nits,
would like an integration test for forge remappings with remappings.txt
mattsse
requested changes
Aug 8, 2023
b94e9f1 to
40c5317
Compare
40c5317 to
fdefce3
Compare
mattsse
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5561.
The issue highlighted a few edge cases:
starts_with, rather than containsSolution
into_innermethod to the wrapper which produces a vector of remappings that are unique.