fix: add is dynamic fee fn#5546
Merged
mattsse merged 1 commit intofoundry-rs:masterfrom Aug 5, 2023
mattsse:matt/dynamic-fee-cond
Merged
fix: add is dynamic fee fn#5546mattsse merged 1 commit intofoundry-rs:masterfrom mattsse:matt/dynamic-fee-cond
mattsse merged 1 commit intofoundry-rs:masterfrom
mattsse:matt/dynamic-fee-cond
Conversation
Evalir
approved these changes
Aug 5, 2023
| let mut transaction: Transaction = eth_transaction.clone().into(); | ||
|
|
||
| if let TypedTransaction::EIP1559(_) = eth_transaction.as_ref() { | ||
| if eth_transaction.is_dynamic_fee() { |
Member
There was a problem hiding this comment.
right, this properly "inverts" the check that used to happen below with !is_eip1559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regression in #5534 where type was removed
this changes the if condition by add a is_dynamic_fee and not resetting the tx type in the else branch
cc @DaniPopes