Skip to content

chore(update constants): increment solc versions for install_commonly… #5504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 2 commits into from
Jul 29, 2023
Merged

chore(update constants): increment solc versions for install_commonly… #5504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d01970
chore(update constants): increment solc versions for install_commonly…
sambacha Jul 29, 2023
bdaf1dc
rename vars
mattsse Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/test-utils/src/util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,9 @@ pub fn setup_cast_project(test: TestProject) -> (TestProject, TestCommand) {
fn install_commonly_used_solc() {
let mut is_preinstalled = PRE_INSTALL_SOLC_LOCK.lock();
if !*is_preinstalled {
let v0_8_18 = std::thread::spawn(|| Solc::blocking_install(&"0.8.18".parse().unwrap()));
let v0_8_19 = std::thread::spawn(|| Solc::blocking_install(&"0.8.19".parse().unwrap()));
let v0_8_20 = std::thread::spawn(|| Solc::blocking_install(&"0.8.20".parse().unwrap()));
let v0_8_21 = std::thread::spawn(|| Solc::blocking_install(&"0.8.21".parse().unwrap()));

let wait = |res: std::thread::JoinHandle<_>| -> Result<(), ()> {
if let Err(err) = res.join().unwrap() {
Expand All @@ -208,7 +208,7 @@ fn install_commonly_used_solc() {
};

// only set to installed if succeeded
*is_preinstalled = wait(v0_8_18).and(wait(v0_8_19)).and(wait(v0_8_20)).is_ok();
*is_preinstalled = wait(v0_8_19).and(wait(v0_8_20)).and(wait(v0_8_21)).is_ok();
}
}

Expand Down